Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings will be hard errors from clang-16 #85

Closed
RCasatta opened this issue Oct 14, 2024 · 2 comments
Closed

Warnings will be hard errors from clang-16 #85

RCasatta opened this issue Oct 14, 2024 · 2 comments

Comments

@RCasatta
Copy link
Contributor

RCasatta commented Oct 14, 2024

In the CI there are some warnings:

warning: [email protected]: In file included from depend/secp256k1/src/secp256k1.c:23:
warning: [email protected]: In file included from depend/secp256k1/src/assumptions.h:12:
warning: [email protected]: depend/secp256k1/src/util.h:30:5: warning: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Wimplicit-function-declaration]
warning: [email protected]:     printf("{");
warning: [email protected]:     ^
warning: [email protected]: depend/secp256k1/src/util.h:30:5: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'

If I understand correctly what's happening in a downstream library this will become hard errors from clang-16

Error in downstream library:

warning: In file included from depend/secp256k1/src/secp256k1.c:23:
warning: In file included from depend/secp256k1/src/assumptions.h:12:
warning: depend/secp256k1/src/util.h:30:5: error: call to undeclared library function 'printf' with type 'int (const char *, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
warning:     printf("{");
warning:     ^
warning: depend/secp256k1/src/util.h:30:5: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'
warning: 1 error generated.

error: failed to run custom build command for `secp256k1-zkp-sys v0.10.0`

@apoelstra
Copy link
Contributor

Should port rust-bitcoin/rust-secp256k1#735 to here which deletes this (totally unused) code.

@RCasatta
Copy link
Contributor Author

Fixed by #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants