Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WASM #86

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

uncomputable
Copy link
Contributor

Port of rust-bitcoin/rust-secp256k1#735

Let's see if this passes CI. I can run cargo build --target wasm32-unknown-unknown after my commit.

Generating the .patch files was kind of hard. Is there an easy way?

Remove printf statement which makes wasm build fail.
@uncomputable
Copy link
Contributor Author

There are strictly more checkmarks than on master :)

Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 454a9aa; successfully ran local tests; thanks!!

@apoelstra apoelstra merged commit 0a3e73c into BlockstreamResearch:master Oct 18, 2024
12 of 14 checks passed
@uncomputable uncomputable deleted the 2024-10-fix-wasm branch October 19, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants