Small bronze and steel boilers ash #1302
Comments
SteelGiant87
added a commit
to SteelGiant87/GT5-Unofficial
that referenced
this issue
Nov 26, 2017
Issue: Small boilers that had ash in the byproduct slot would not produce more byproduct if the fuel type was changed to one that produced a different type of ash e.g. burn a couple of coal until there is one DarkAsh in the byproduct slot, then charcoal will produce no Ash in that stack Fix: When mixing ash types, convert all the ash to less valuable light ashes - prevents any exploits for creating more dark ashes. Issue: Boilers did not stop burning fuel when full of ash Fix: added explicit check so that boilers can't burn fuel when output is stuffed (this may be a balance change, so can be removed if undesirable) Small refactoring of fuel logic so that ash conversion logic does not need to be repeated Started with small bronze boiler, will extend fix to small steel boiler if general structure approved Addresses issue Blood-Asp#1302
This was referenced Nov 26, 2017
Blood-Asp
pushed a commit
that referenced
this issue
Feb 10, 2018
* Bugfix: Small boiler ash types mixing Issue: Small boilers that had ash in the byproduct slot would not produce more byproduct if the fuel type was changed to one that produced a different type of ash e.g. burn a couple of coal until there is one DarkAsh in the byproduct slot, then charcoal will produce no Ash in that stack Fix: When mixing ash types, convert all the ash to less valuable light ashes - prevents any exploits for creating more dark ashes. Issue: Boilers did not stop burning fuel when full of ash Fix: added explicit check so that boilers can't burn fuel when output is stuffed (this may be a balance change, so can be removed if undesirable) Small refactoring of fuel logic so that ash conversion logic does not need to be repeated Started with small bronze boiler, will extend fix to small steel boiler if general structure approved Addresses issue #1302 * Fixed imports and typo * Extended change to small steel boiler as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, small boilers will stop producing ash output if the fuel type is changed
e.g. Burn some coal until one dark ash is produced, then switch to burning charcoal. The burning charcoal will never produce byproduct and the output stack will stay at one dark ash.
Additionally, in the code there doesn't seem to be anything that prevents the boiler from working once the byproduct stack is full, it will just keep working but stop adding byproduct (I may be wrong on this, have not been able to test).
Proposed fixes are:
to change the output type to (light) ash whenever the boiler attempts to mix ash types. Light ash is chosen as it is the less valuable one, thus preventing any benefits/exploits from this change.
Have the boilers explicitly check that the output is not choked before attempting to burn more fuel.
Fix 2 could be a balance change, as it would make boilers harder to automate, so this part could be omitted. I thought this was the way it was supposed to behave so I am happy to be corrected if this is not the case.
I have a pull request that fixes both these issues, and I have been able to test it.
The text was updated successfully, but these errors were encountered: