Bugfix: Small boiler ash types mixing #1303
Conversation
Issue: Small boilers that had ash in the byproduct slot would not produce more byproduct if the fuel type was changed to one that produced a different type of ash e.g. burn a couple of coal until there is one DarkAsh in the byproduct slot, then charcoal will produce no Ash in that stack Fix: When mixing ash types, convert all the ash to less valuable light ashes - prevents any exploits for creating more dark ashes. Issue: Boilers did not stop burning fuel when full of ash Fix: added explicit check so that boilers can't burn fuel when output is stuffed (this may be a balance change, so can be removed if undesirable) Small refactoring of fuel logic so that ash conversion logic does not need to be repeated Started with small bronze boiler, will extend fix to small steel boiler if general structure approved Addresses issue Blood-Asp#1302
|
I have now been able to build GT5u and test these changes. Both changes work in that small bronze boilers stop when blocked with ash, and mixed ash stacks combine to light ash. If these changes are wanted, then I can extend them to the small steel HP boiler as well. |
|
If you're doing it for one, then it's sort of expected to change the behaviours for them all.. |
|
Agreed, I was just starting out with one of them as the code is very similar and I didn't want to change too much duplicated code in case people wanted a different overall direction. If you and the other devs are happy with the general direction of these changes, then I'll change the Small HP Steel boiler as well this evening. |
|
This change now affects both the small bronze boiler and the small steel boiler, and I have checked that it functions for both. |
|
Another question: What happens if dust output is full? |
|
If dust output is full, then the boiler is unable to start burning another piece of fuel and will start to cool down. |
Issue: Small boilers that had ash in the byproduct slot would not produce more byproduct if the fuel type was changed to one that produced a different type of ash e.g. burn a couple of coal until there is one DarkAsh in the byproduct slot, then charcoal will produce no Ash in that stack
Fix: When mixing ash types, convert all the ash to less valuable light ashes - prevents any exploits for creating more dark ashes.
Issue: Boilers did not stop burning fuel when full of ash
Fix: added explicit check so that boilers can't burn fuel when output is stuffed (this may be a balance change, so can be removed if undesirable)
Small refactoring of fuel logic so that ash conversion logic does not need to be repeated
Started with small bronze boiler, will extend fix to small steel boiler if general structure approved
Addresses issue #1302