-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT6 cable quality of life improvements #1349
GT6 cable quality of life improvements #1349
Conversation
…s the wire, for a connect/disconnect
Just for a heads up might fuck up current behaviour of soldering iron on machine sides... |
By that i mean it overlaps with it, even if there is a check what should happen an overlapping behaviour is bad imo. Just a matter of preference. |
Other idea would be to implement other tool for "electical" wire soldering/cutting. like electric wire cramping/cutting tool |
Reverted the soldering iron changes; left the wire cutter right click behavior. |
@mitchej123 cherrypick this commit to that merge branch |
…ng trough gt machine blocks work only if the player is isneaking. And because of that, added back the soldering iron support.
Two main pieces: 1) Updates solar panel (cover) behavior to always show connected, and allows connect() to work without a tile entity. This bit is mostly optional and mainly included so the client renders the panels as connected. 2) Updates injectEnergy() to allow injection from unconnected, but UNKNOWN directions (6) - which is what solar panels and transformers use.
Included a fix for an issue with gt6 style wires and GT solar panels (covers) that some players noticed. CC |
} | ||
} | ||
|
||
boolean sHasSolarPanel = coverBehavior instanceof GT_Cover_SolarPanel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned downstream - I don't love this; but I'm not aware of any other "covers" that inject energy. Also it's the only connection that doesn't require a tile entity on the other side.
Added a fix for cables & AE2 GT EU p2p tunnels |
Allow use of wire cutter/soldering item on the tile entity, as well as the wire, for a connect/disconnect. Useful for when the cable you want to power the machine is hidden behind the machine and not easily accessible.
Porting upstream from GTNewHorizons/GT5-Unofficial#64