Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT6 cable quality of life improvements #1349

Merged
merged 5 commits into from
Feb 10, 2018
Merged

GT6 cable quality of life improvements #1349

merged 5 commits into from
Feb 10, 2018

Conversation

mitchej123
Copy link
Contributor

Allow use of wire cutter/soldering item on the tile entity, as well as the wire, for a connect/disconnect. Useful for when the cable you want to power the machine is hidden behind the machine and not easily accessible.

Porting upstream from GTNewHorizons/GT5-Unofficial#64

@Technus
Copy link
Contributor

Technus commented Dec 25, 2017

Just for a heads up might fuck up current behaviour of soldering iron on machine sides...
which changes the strenght of redstone signal emmited

@Technus
Copy link
Contributor

Technus commented Dec 25, 2017

By that i mean it overlaps with it, even if there is a check what should happen an overlapping behaviour is bad imo.

Just a matter of preference.

@Technus
Copy link
Contributor

Technus commented Dec 25, 2017

Other idea would be to implement other tool for "electical" wire soldering/cutting.

like electric wire cramping/cutting tool

@mitchej123
Copy link
Contributor Author

Reverted the soldering iron changes; left the wire cutter right click behavior.

@Technus
Copy link
Contributor

Technus commented Dec 25, 2017

@mitchej123 cherrypick this commit to that merge branch
GTNewHorizons/GT5-Unofficial@c89acf5

Technus and others added 2 commits December 25, 2017 22:03
…ng trough gt machine blocks work only if the player is isneaking. And because of that, added back the soldering iron support.
Two main pieces:
1) Updates solar panel (cover) behavior to always show connected, and
allows connect() to work without a tile entity.  This bit is mostly
optional and mainly included so the client renders the panels as
connected.

2) Updates injectEnergy() to allow injection from unconnected, but
UNKNOWN directions (6) - which is what solar panels and transformers
use.
@mitchej123
Copy link
Contributor Author

Included a fix for an issue with gt6 style wires and GT solar panels (covers) that some players noticed. CC

CC @Antifluxfield

}
}

boolean sHasSolarPanel = coverBehavior instanceof GT_Cover_SolarPanel;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned downstream - I don't love this; but I'm not aware of any other "covers" that inject energy. Also it's the only connection that doesn't require a tile entity on the other side.

@mitchej123
Copy link
Contributor Author

Added a fix for cables & AE2 GT EU p2p tunnels

@Blood-Asp Blood-Asp merged commit 5cb5bd0 into Blood-Asp:unstable Feb 10, 2018
@mitchej123 mitchej123 deleted the bloody_gt6_cables_quality_of_life_enhancements branch February 11, 2018 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants