GT6 cable quality of life improvements #64
Conversation
…s the wire, for a connect/disconnect
|
@Dream-Master - Fixing an annoyance I've had with the new style cables (which in general I'm a fan of) |
|
Sounds cool i will add it @mitchej123 thanks |
|
Just for a heads up might fuck up current behaviour of soldering iron on machine sides... |
|
By that i mean it overlaps with it, even if there is a check what should happen an overlapping behaviour is bad imo. Just a matter of preference. |
| mStrongRedstone ^= (1 << tSide); | ||
| GT_Utility.sendChatToPlayer(aPlayer, trans("091","Redstone Output at Side ") + tSide + trans("092"," set to: ") + ((mStrongRedstone & (1 << tSide)) != 0 ? trans("093","Strong") : trans("094","Weak"))); | ||
| GT_Utility.sendSoundToPlayers(worldObj, GregTech_API.sSoundList.get(103), 3.0F, -1, xCoord, yCoord, zCoord); | ||
| } else if (mMetaTileEntity.onSolderingToolRightClick(aSide, tSide, aPlayer, aX, aY, aZ)) { |
There was a problem hiding this comment.
just generally does shit and then discharges it? I would just use the discharged tool all the way,
|
summin up only wirecutter for wires/cables soldeirng iron for redstone signals (revert the code that changed it and make it only do that if someone implemented connection tool on soldering iron) only wrench for pipes |
| } | ||
|
|
||
| @Override | ||
| public boolean onSolderingToolRightClick(byte aSide, byte aWrenchingSide, EntityPlayer aPlayer, float aX, float aY, float aZ) { |
There was a problem hiding this comment.
lets just reserve that for only redstone level changes
| mStrongRedstone ^= (1 << tSide); | ||
| GT_Utility.sendChatToPlayer(aPlayer, trans("091","Redstone Output at Side ") + tSide + trans("092"," set to: ") + ((mStrongRedstone & (1 << tSide)) != 0 ? trans("093","Strong") : trans("094","Weak"))); | ||
| GT_Utility.sendSoundToPlayers(worldObj, GregTech_API.sSoundList.get(103), 3.0F, -1, xCoord, yCoord, zCoord); | ||
| } else if (mMetaTileEntity.onSolderingToolRightClick(aSide, tSide, aPlayer, aX, aY, aZ)) { |
There was a problem hiding this comment.
this is like the opposite of how this should work?
If tool was used then do it
instead of if did it use the tool
|
Other idea would be to implement other tool for "electical" wire soldering/cutting. like electric wire cramping/cutting tool |
* Fix exploit with disassembler * spotlessApply
* fix * spotlessApply (#64) Co-authored-by: GitHub GTNH Actions <> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s-fixes Spotless apply for branch delete-unused-stuff for #64
Allow use of wire cutter/soldering item on the tile entity, as well as the wire, for a connect/disconnect. Useful for when the cable you want to power the machine is hidden behind the machine and not easily accessible.