Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated viewer module #1032

Merged
merged 4 commits into from
May 3, 2022
Merged

Remove deprecated viewer module #1032

merged 4 commits into from
May 3, 2022

Conversation

eleftherioszisis
Copy link
Contributor

No description provided.

@@ -28,6 +28,4 @@

"""View tools to visualize morphologies."""
from neurom.view.matplotlib_impl import (plot_morph, plot_morph3d,
plot_tree, plot_tree3d,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgeplf , just to verify after our discussion, we do want to hide these. right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see their utility, but on the other hand, they're part of the API, and someone may have used them.

I guess we have 3 choices:

  1. Leave things how they are
  2. Mark them as deprecated, and remove them later
  3. Remove them now, explain in Changelog that they just aren't as visible, and to give feedback if they are needed.

I think 3 is a fine compromise, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is good to go now, right?

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v4@57b634d). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             v4     #1032   +/-   ##
======================================
  Coverage      ?   100.00%           
======================================
  Files         ?        35           
  Lines         ?      2457           
  Branches      ?         0           
======================================
  Hits          ?      2457           
  Misses        ?         0           
  Partials      ?         0           

@eleftherioszisis eleftherioszisis merged commit f6451f6 into v4 May 3, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/remove-viewer branch May 3, 2022 08:00
eleftherioszisis added a commit that referenced this pull request Jun 7, 2022
Removes viewer deprecated module and hides plot_tree, plot_tree3d, plot_soma, plot_soma3d from neurom.view

Co-authored-by: Zisis Eleftherios <[email protected]>
eleftherioszisis pushed a commit that referenced this pull request May 14, 2024
* Mixed subtree processing (#981)
* Refactor tests for test_mixed.py (#1027)
* Remove deprecated modules and functions/classes & warnings (#1026, #1032)
* Use readonly morphio Morphology by default (#979)
* Morphology level radial distance features use the soma as reference point (#1030)
* Expose subtree processing from the morph_stats api (#1034)
* Remove pyXX prefix for lint, docs, and coverage (#1038)
* Fix tutorials and add tutorial testenv (#1039)
* Add isort for formatting/linting (#1040)
* Add testing of example scripts (#1041)
* Make documentation/docstrings testable (#1035)
* Add black to neurom, format everything, and add to lint (#1042)
* Fix load_morpholgies to always resolve paths (#1047)
* allow Morphology objects to be either mut or immut (#1049)
* Replace iter_* methods by properties in core objects and improve iter_segments (#1054)
* Decouple Morphology constructor from io (#1120)
* Move soma methods to functions (#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants