-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIWebview -> WKWebView ( Tested ) #334
Conversation
Hi @roremeol! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Sorry, i can't help you! As you, i'm only a programar who has problems to submit an app to Apple‘s Store and i don't have privilege enough to do it. If it can help you i changed the Bolts‘s source inside my project on Pods folder. Beast regards |
Ohhh okay .... anyways thanks for your work mate. Really saved me. |
@nlutsenko Can you please add this in a release. If I run pod install it is currently not getting the latest code. |
@nlutsenko Could you make a new release? |
Any update ? |
The new release is up for a while now. |
This is still broken somewhere (perhaps Bolts? Apple doesn't say), but my app is still being rejected from the store because of UIWebView usage. |
@dwhipps Don't think so. I have been able to submit multiple apps without any issue of this |
@dwhipps Try to find “UIWebView” inside pods folder, maybe there is one or more dependicies who still does not update there source. |
My mistake. This was another library altogether, which was also using UIWebView (an older version of OneSignal.framework if you're curious.) Sorry for the false alarm. Apple doesn't say where they found the problem, so it's been a lot of frustrating trial and error. |
This pull request replaces use of deprecated UIWebView with WKWebView allowing Bolts-ObjC to be used without Apple's warning emails about deprecation of UIWebView.
This code have passed for all tests.