Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MX-462] - Disable idfa access by Facebook sdk #3809

Merged
merged 4 commits into from
Sep 1, 2020

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Sep 1, 2020

The type of this PR is: Chore

This PR resolves MX-462

Description

  • Updates Facebook sdk to version that supports disabling access to idfa
  • Adds plist value to disable access
  • Removes access to idfa in admin menu

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)

Update facebook sdk, disable access to idfa

Update changelog
@brainbicycle brainbicycle marked this pull request as draft September 1, 2020 19:25
Copy link
Contributor

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I'm surprised the Facebook SDK update wasn't more onerous, that's great.

I've checked the Bolts changelog and they removed UIWebView in 1.9.1 so we should be set for the UIWebView transition 🎉

@brainbicycle
Copy link
Contributor Author

Looks good 👍 I'm surprised the Facebook SDK update wasn't more onerous, that's great.

I've checked the Bolts changelog and they removed UIWebView in 1.9.1 so we should be set for the UIWebView transition 🎉

Yeah I was pleasantly surprised that it just worked!

@brainbicycle brainbicycle marked this pull request as ready for review September 1, 2020 20:07
@artsy-peril artsy-peril bot merged commit e54757f into master Sep 1, 2020
@artsy-peril artsy-peril bot deleted the brian/facebook-idfa branch September 1, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants