Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user option to composer::project #10

Closed
mbrodala opened this issue Jan 27, 2015 · 4 comments · Fixed by #11
Closed

Add user option to composer::project #10

mbrodala opened this issue Jan 27, 2015 · 4 comments · Fixed by #11

Comments

@mbrodala
Copy link
Contributor

ATM composer::project is evaluated with user root which has disadvantages:

  1. Usually SSH keys for repository access are not set up for root but for a regular user instead: create-project command fails on private repositories.
  2. The created directory is owned by root: ownership has to be changed to an unprivileged user.

Thus a $user option (which may default to $composer::params::user) should be added which is applied to all exec resources within composer::project.

@igalic
Copy link
Contributor

igalic commented Jan 27, 2015

+1
@mbrodala do you wanna propose your own pr?

@mbrodala
Copy link
Contributor Author

Sure but first I'd like to get #9 merged to avoid rebasing issues. ;-)

@igalic
Copy link
Contributor

igalic commented Jan 27, 2015

let's get this one in too, and then make a new release!

@mbrodala
Copy link
Contributor Author

I'll give it a try in the next days. :-)

mbrodala added a commit to mbrodala/puppet-composer that referenced this issue Jan 29, 2015
This option allows for setting a specific user to create composer projects
with. This is useful e.g. to have a SSH key of a user used for Git clones.

Fixes Brainsware#10
mbrodala added a commit to mbrodala/puppet-composer that referenced this issue Jan 29, 2015
This option allows for setting a specific user to create composer projects
with. This is useful e.g. to have a SSH key of a user used for Git clones.

Fixes Brainsware#10
mbrodala added a commit to mbrodala/puppet-composer that referenced this issue Jan 29, 2015
This option allows for setting a specific user to create composer projects
with. This is useful e.g. to have a SSH key of a user used for Git clones.

Fixes Brainsware#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants