Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to create project from package #9

Merged
merged 1 commit into from
Jan 27, 2015

Conversation

mbrodala
Copy link
Contributor

This internally invokes Composer's create-project command which allows for
creating projects based on other packages. To reduce the number of options the
shorthand syntax <package>:<version> supported by Composer is promoted.

Fixes #8

To create a project based on another package we can use the `$source`

```puppet
composer::project {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need a title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@igalic
Copy link
Contributor

igalic commented Dec 24, 2014

general notices: thank you very much!

  • travis is failing, but that doesn't seem to be your doing! (since when is composer-self-update failing?, and why didn't i notice earlier?!?)
  • it would be nice to add a spec test for this new feature

@mbrodala mbrodala force-pushed the create-project branch 2 times, most recently from d8835ca to 412d8f5 Compare December 29, 2014 14:40
@igalic
Copy link
Contributor

igalic commented Jan 5, 2015

i'll look into fixing the travis issue, and then merge this.


obligatory addendum: really sorry i left this unattended so long ._. i didn't really touch computers during the holidays

@igalic
Copy link
Contributor

igalic commented Jan 27, 2015

@mbrodala i've now fixed tests in master, would you mind rebasing?


git remote add upstream [email protected]:Brainsware/puppet-composer.git
git remote update
git rebase upstream/master
git push -f origin create-project

This internally invokes Composer's "create-project" command which allows for
creating projects based on other packages. To reduce the number of options the
shorthand syntax "<package>:<version>" supported by Composer is promoted.

Fixes Brainsware#8
@mbrodala
Copy link
Contributor Author

Had to replace the plain true call with /bin/true to satisfy Puppet with STRICT_VARIABLES=yes but now tests seem fine.

igalic added a commit that referenced this pull request Jan 27, 2015
Add option to create project from package
@igalic igalic merged commit 49b06e8 into Brainsware:master Jan 27, 2015
@igalic
Copy link
Contributor

igalic commented Jan 27, 2015

thaaaaanks @mbrodala!

@mbrodala mbrodala deleted the create-project branch January 27, 2015 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate option to create project
2 participants