Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer::repository type #16

Merged
merged 1 commit into from
Mar 11, 2015
Merged

Add composer::repository type #16

merged 1 commit into from
Mar 11, 2015

Conversation

mbrodala
Copy link
Contributor

This type allows for managing composer repositories either locally in
project directories or globally.

@mbrodala
Copy link
Contributor Author

Notice that this new type currently duplicates some code from composer::project. This needs some refactoring after merging this.

I would also like to have a more readable version of the unless line.

This type allows for managing composer repositories either locally in
project directories or globally.
@mbrodala
Copy link
Contributor Author

@igalic Could you have a look at the Ruby 1.8.7 build failures?

@igalic
Copy link
Contributor

igalic commented Mar 4, 2015

i have no idea how rspec or ruby works sometimes #17

@mbrodala
Copy link
Contributor Author

How to proceed here? The failing tests are not triggered by this change after all.

@igalic
Copy link
Contributor

igalic commented Mar 11, 2015

you're right! let's get this merged, and fix the tests separately

igalic added a commit that referenced this pull request Mar 11, 2015
@igalic igalic merged commit e8ffbde into master Mar 11, 2015
@mbrodala
Copy link
Contributor Author

Thanks. :-) Next thing is refactoring of the environment bits.

@igalic
Copy link
Contributor

igalic commented Mar 11, 2015

yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants