pin rspec-core to version that works w/ruby 1.8.7 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! and now we're hitting rodjek/rspec-puppet#227 |
|
@attachmentgenie fixed their tests for ufw, which were failing for similar reasons, here: attachmentgenie/attachmentgenie-ufw@4fc3c62 |
this fix is analogous to puppetlabs/puppetlabs-puppetdb#167
like @raphink did in 7fba86e979815c180f3f5b813d2e2bb394f84ecb
|
finally…ish…maybe… |
igalic
added a commit
that referenced
this pull request
Mar 19, 2015
pin rspec-core to version that works w/ruby 1.8.7
|
@mbrodala ^ it's done. sorry took so long |
|
No worries. Guess you're happy if Ruby 1.8.7 dies. ;-) |
|
so, so, so very happy… when all of software dies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix is analogous to
puppetlabs/puppetlabs-puppetdb#167