[backends] Fix behavior of MoviePy backend #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still some fixes required in MoviePy itself to make corrupt video tests pass.
Breakthrough
force-pushed
the
issue-461-moviepy_2.0
branch
from
7752af0 to
a432a76
Compare
Skip corrupt video test on MoviePy awaiting Zulko/moviepy#2253
Breakthrough
force-pushed
the
issue-461-moviepy_2.0
branch
3 times, most recently
from
18ad778 to
92b5349
Compare
Breakthrough
force-pushed
the
issue-461-moviepy_2.0
branch
from
92b5349 to
10fba27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MoviePy backend for release of MoviePy 2.0. With these changes, the MoviePy backend should work correctly across all versions.
There are still some fixes required in MoviePy itself to make corrupt video tests pass so we might have to skip running those for now until those fixes can be pushed. I've submitted a PR to the project which can allow those tests to pass:
Zulko/moviepy#2253