Make FFMPEG_VideoReader more robust to missing information.
#2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakthrough
added a commit
to Breakthrough/PySceneDetect
that referenced
this pull request
Nov 23, 2024
Breakthrough
added a commit
to Breakthrough/PySceneDetect
that referenced
this pull request
Nov 23, 2024
Skip corrupt video test on MoviePy awaiting Zulko/moviepy#2253
Breakthrough
added a commit
to Breakthrough/PySceneDetect
that referenced
this pull request
Nov 23, 2024
Skip corrupt video test on MoviePy awaiting Zulko/moviepy#2253
Breakthrough
added a commit
to Breakthrough/PySceneDetect
that referenced
this pull request
Nov 23, 2024
* [backends] Fix behavior of MoviePy backend There are still some fixes required in MoviePy itself to make corrupt video tests pass. * [backends] Fix MoviePy 2.0 EOF behavior Skip corrupt video test on MoviePy awaiting Zulko/moviepy#2253 * [build] Enable Moviepy tests for builds and document workarounds for #461
Allow `FFMPEG_VideoReader` to function more robustly in the presence of missing information. Fixes Zulko#2256
|
Passes unit tests locally and ensured code is formatted. |
|
Thank you, I just released it under moviepy==2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
FFMPEG_VideoReaderto function more robustly in the presence of missing information.I have a variety of existing tests in my project PySceneDetect that began to fail suddenly during the update to MoviePy 2.0. Some of these tests include loading corrupt videos, and testing how the FFMPEG_VideoReader class responds to certain seeking and EOF behaviors.
In previous versions, a video under test would read the first 45 frames or so before failing, but with the latest version, it throws an exception when trying to create the
FFMPEG_VideoReader. This PR has the required changes to make loading the video more robust to the missing information to still allow corrupt files to be processed, even if incompletely.Resolves #2256