2.0.0-rc.1 #158
Merged
2.0.0-rc.1 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying inquiry evidence from session helper to session data structures.
…ts for session helper
* WIP load users * Add functionality to support no data directory and lint * remove unused import * Add unittest examples with some direction * Testing Testing uploaded code 2 * Ran Make Lint Command Final edit before PR * change input into load_users, update tests Co-authored-by: Alister <[email protected]> Co-authored-by: Tab Memmott <[email protected]>
* EDF conversion fixes
Session module
* Inquiry Preview Display and Key Input Method
#176581753 ; added timeout to acquisition connector
- export offline_analysis and return figure handles from generate_offline_analysis_screen() to allow testing - Add integration tests in bcipy/signal/tests/model/test_offline_analysis.py, asserting model's current behavior for: - AUC (number only, no contents of pkl file) - lik_dens figure - mean_erp figure - Add unit tests in bcipy/signal/tests/model/test_model.py, asserting model's current behavior - Remove unused grid_search() function from cross_validation.py - Add placeholder tests for notch and bandpass - Add some notes in model training code - Removing unnecessary folders, formatting, and removing unused code from demos - Remove unnecessary DummyDimReduction - Rename "mach_learning" to "ml TODO - it might be worth considering deleting or updating the demos at bcipy/signal/model/demo/ml
- move demos back to original location
Add abstract base class for SignalModel
…( python >=3.7 ) - add test_producer_end
#176151285 ; use stim_length parameter
…that fixation stimuli are labeled as 'fixation' rather than 'nontarget'
#181490020 ; Remove old lm params
#181489190 ; Session fixation labels
#181987601 move session script to demo
#181038299 ; acquisition module docs
lawhead
previously approved these changes
Apr 28, 2022
nik-sm
previously approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
2.0.0-rc.1
Contributions
Test
make test-allDocumentation