Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce LoRa Concentrator Management #240

Merged
merged 36 commits into from
Feb 10, 2022
Merged

Introduce LoRa Concentrator Management #240

merged 36 commits into from
Feb 10, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Feb 10, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Sben65 and others added 28 commits February 9, 2022 15:00
@Sben65
add of concentrator page list
80b68c5
@Sben65
concentrator controller
9082295
@Sben65
add of default properties
a1bcbd0
@Sben65
add of create function in concentratorsController
795589d
@Sben65
change the folder name
9e1b81c
@Sben65
change the old links
1da0799
@Sben65
add create concentrator page with required properties
1ab9d5a
@Sben65
functional update, delete and detail
abc0936
@Sben65
update desired properties of concentrator
a93ad0e
@Sben65
add of test
546aa51
@kbeaugrand
Add mocked httpClient
4dd4ad2
@Sben65
add of concentrator page list
76250a4
@Sben65
concentrator controller
e80cea7
@Sben65
add of default properties
a85fabf
@Sben65
add of create function in concentratorsController
8d93cf8
@Sben65
change the folder name
d3f17e8
@Sben65
change the old links
4559bc0
@Sben65
add create concentrator page with required properties
d33579c
@Sben65
functional update, delete and detail
260ff0e
@Sben65
update desired properties of concentrator
4373a2b
@Sben65
add of test
ac6bb24
@Sben65
add of RouterConfigManager
c9cbdfc
@kbeaugrand @Sben65
Add mocked httpClient
633adbf
@Sben65
concentratorsControllerTest + concentratorsTwinMapperTest
d9cacdc
@Sben65
fix #192
e9a71bc
@Sben65
resolve bug
3b2ae5c
@Sben65
fix #192
3130a2d
@Sben65
...
b6069aa
@Sben65 Sben65 requested a review from kbeaugrand February 10, 2022 15:57
@Sben65 Sben65 requested a review from a team as a code owner February 10, 2022 15:57
@Sben65 Sben65 linked an issue Feb 10, 2022 that may be closed by this pull request
Story: As a user I Want to Manage LoRa Devices and LoRa Concentrator on my platform #192
Closed
3 tasks
@Sben65 Sben65 removed a link to an issue Feb 10, 2022
Story: As a user I Want to Manage LoRa Devices and LoRa Concentrator on my platform #192
Closed
3 tasks
@Sben65 Sben65 linked an issue Feb 10, 2022 that may be closed by this pull request
Task: Manage LoRa Concentrator on the portal #173
Closed
@codecov
Copy link

codecov bot commented Feb 10, 2022 •
edited
Loading

Codecov Report

Merging #240 (f3dab7a) into main (1cbb513) will increase coverage by 3.07%.
The diff coverage is 42.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   17.15%   20.22%   +3.07%     
==========================================
  Files          67       77      +10     
  Lines        2005     2269     +264     
==========================================
+ Hits          344      459     +115     
- Misses       1661     1810     +149
Impacted Files Coverage Δ
...nt/Pages/Edge_Devices/ConnectionStringDialog.razor 0.00% <ø> (ø)
...nt/Pages/Edge_Devices/CreateEdgeDeviceDialog.razor 0.00% <ø> (ø)
...e_Devices/EdgeDeviceDeleteConfirmationDialog.razor 0.00% <ø> (ø)
...ient/Pages/Edge_Devices/EdgeDeviceDetailPage.razor 0.00% <0.00%> (ø)
...Client/Pages/Edge_Devices/EdgeDeviceListPage.razor 0.00% <0.00%> (ø)
...l/Client/Pages/Edge_Devices/ModuleLogsDialog.razor 0.00% <ø> (ø)
.../LoRaWAN/Concentrator/ConcentratorDetailPage.razor 0.00% <0.00%> (ø)
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 0.00% <0.00%> (ø)
.../LoRaWAN/Concentrator/CreateConcentratorPage.razor 0.00% <0.00%> (ø)
.../LoRaWAN/Concentrator/DeleteConcentratorPage.razor 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbb513...f3dab7a. Read the comment docs.

kbeaugrand
kbeaugrand requested changes Feb 10, 2022
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include #241 (at least the deploy setting in this PR)

src/AzureIoTHub.Portal/Client/Pages/Edge_Devices/ModuleLogsDialog.razor Outdated Show resolved Hide resolved
@kbeaugrand kbeaugrand changed the title Issue #192 add lo ra concentrator Introduct LoRa Concentrator Management Feb 10, 2022
@kbeaugrand kbeaugrand changed the title Introduct LoRa Concentrator Management Introduce LoRa Concentrator Management Feb 10, 2022
@kbeaugrand kbeaugrand force-pushed the issue_#192_add_LoRa_concentrator branch from 3dc09d0 to fb877a7 Compare February 10, 2022 19:03
@kbeaugrand kbeaugrand self-requested a review February 10, 2022 20:27
@kbeaugrand kbeaugrand force-pushed the issue_#192_add_LoRa_concentrator branch from eb30b69 to f3dab7a Compare February 10, 2022 20:38
@kbeaugrand kbeaugrand merged commit 01d412f into main Feb 10, 2022
@kbeaugrand kbeaugrand deleted the issue_#192_add_LoRa_concentrator branch February 10, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Manage LoRa Concentrator on the portal
2 participants
@Sben65 @kbeaugrand