Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcs update #13

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Gcs update #13

merged 7 commits into from
Feb 28, 2024

Conversation

marcasmar1
Copy link
Collaborator

No description provided.

@marcasmar1
Copy link
Collaborator Author

This pull request fails the changelog test, but as the current version hasn't been uploaded, it wouldn't make any sense to increase the version.
Current version:

0.6.2+schema.0.4.1

  • Created format document guide

@marcasmar1 marcasmar1 requested a review from aleokdev February 25, 2024 17:26
Copy link
Collaborator

@aleokdev aleokdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got some feedback. Also, did you check if these JSON files are successfully parsed by track2kml?

docs/src/common_uses/basic_example.md Show resolved Hide resolved
@marcasmar1
Copy link
Collaborator Author

Ok, got some feedback. Also, did you check if these JSON files are successfully parsed by track2kml?

Yes, I've succesfully created their corresponding kml files.

docs/src/track2kml/track2kml.md Outdated Show resolved Hide resolved
docs/src/track2kml/track2kml.md Outdated Show resolved Hide resolved
@aleokdev
Copy link
Collaborator

@marcasmar1 All good to merge?

@marcasmar1
Copy link
Collaborator Author

@marcasmar1 All good to merge?

No, actually.
There's still work to do on the Basic example page.

@marcasmar1 marcasmar1 requested a review from aleokdev February 28, 2024 12:24
Copy link
Collaborator

@aleokdev aleokdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good to me.

@aleokdev
Copy link
Collaborator

@marcasmar1 Can we merge now?

@marcasmar1
Copy link
Collaborator Author

@marcasmar1 Can we merge now?

Yes

@aleokdev aleokdev merged commit df53b2d into main Feb 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants