feat: Emit infallible float→rotation conversions
#560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
ab/infallible-rotations
branch
from
a940193
to
e57aa9a
Compare
qartik
previously approved these changes
Oct 15, 2024
|
We may need some more fixes before updating the tket2 dep -.- |
aborgna-q
force-pushed
the
ab/infallible-rotations
branch
from
a340842
to
4c45d13
Compare
|
I temporarily disabled the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 91.09% 91.08% -0.01%
==========================================
Files 59 59
Lines 6264 6257 -7
==========================================
- Hits 5706 5699 -7
Misses 558 558 ☔ View full report in Codecov by Sentry. |
qartik
approved these changes
Oct 15, 2024
ss2165
pushed a commit
that referenced
this pull request
Oct 21, 2024
Closes #550 - Updates `tket2` dependency to `>0.4.1`, where we added the `tket2.rotation.from_halfturns_unchecked` op - Updates the json extension definitions - Removes the panicking conditional when converting floats into rotations for quantum op params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
#550#549tket2dependency to>0.4.1, where we added thetket2.rotation.from_halfturns_uncheckedop