Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hugr-cli)!: Add Package::validate and return ExtensionRegistry in helpers. #1507

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Sep 3, 2024

BREAKING CHANGE: Add an ExtensionRegistry result to several helpers.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (60e1da0) to head (75ad046).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hugr-cli/src/validate.rs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1507   +/-   ##
=======================================
  Coverage   87.27%   87.28%           
=======================================
  Files         128      128           
  Lines       21718    21721    +3     
  Branches    18718    18721    +3     
=======================================
+ Hits        18955    18959    +4     
  Misses       1990     1990           
+ Partials      773      772    -1     
Flag Coverage Δ
python 92.46% <ø> (ø)
rust 86.45% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this to the hugr-rs 0.12.1 / hugr-py 0.8.1 milestone Sep 3, 2024
@doug-q doug-q changed the title feat(hugr-cli)!: return ExtensionRegistry in helpers feat(hugr-cli)!: Add Package::validate and return ExtensionRegistry in helpers. Sep 4, 2024
@doug-q doug-q marked this pull request as ready for review September 4, 2024 09:25
@doug-q doug-q requested a review from a team as a code owner September 4, 2024 09:25
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@doug-q doug-q added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit f3dafd7 Sep 4, 2024
21 of 23 checks passed
@doug-q doug-q deleted the doug/hugr-cli-tweak branch September 4, 2024 09:36
@hugrbot hugrbot mentioned this pull request Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
## 🤖 New release
* `hugr`: 0.12.0 -> 0.12.1
* `hugr-core`: 0.9.0 -> 0.9.1
* `hugr-passes`: 0.8.0 -> 0.8.1
* `hugr-cli`: 0.5.0 -> 0.6.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.12.1 (2024-09-04)

### Bug Fixes

- `std.collections.insert` wrong output order
([#1513](#1513))

### Features

- Op replacement and lowering functions
([#1509](#1509))
</blockquote>

## `hugr-core`
<blockquote>

## 0.9.1 (2024-09-04)

### Bug Fixes

- `std.collections.insert` wrong output order
([#1513](#1513))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.8.1 (2024-09-04)

### Features

- Op replacement and lowering functions
([#1509](#1509))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.6.0 (2024-09-04)

### Features

- [**breaking**] Allow registry specification in `run_dump`
([#1501](#1501))
- [**breaking**] Add `Package::validate` and return `ExtensionRegistry`
in helpers. ([#1507](#1507))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
@hugrbot hugrbot mentioned this pull request Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2024
## 🤖 New release
* `hugr`: 0.12.1 -> 0.13.0 (✓ API compatible changes)
* `hugr-core`: 0.9.1 -> 0.10.0 (✓ API compatible changes)
* `hugr-passes`: 0.8.1 -> 0.8.2 (✓ API compatible changes)
* `hugr-cli`: 0.6.0 -> 0.6.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.13.0 (2024-10-08)

### Bug Fixes

- [**breaking**] Make list length op give back the list
([#1547](#1547))

### Features

- [**breaking**] Allow CustomConsts to (optionally) be hashable
([#1397](#1397))
- Add an `OpLoadError` variant of `BuildError`.
([#1537](#1537))
- [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return
removed weights ([#1516](#1516))
- Draft for `hugr-model` with export, import, parsing and pretty
printing ([#1542](#1542))
</blockquote>

## `hugr-core`
<blockquote>

## 0.10.0 (2024-10-08)

### Bug Fixes

- [**breaking**] Make list length op give back the list
([#1547](#1547))

### Features

- [**breaking**] Allow CustomConsts to (optionally) be hashable
([#1397](#1397))
- Add an `OpLoadError` variant of `BuildError`.
([#1537](#1537))
- [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return
removed weights ([#1516](#1516))
- Draft for `hugr-model` with export, import, parsing and pretty
printing ([#1542](#1542))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.8.1 (2024-09-04)

### Features

- Op replacement and lowering functions
([#1509](#1509))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.6.0 (2024-09-04)

### Features

- [**breaking**] Allow registry specification in `run_dump`
([#1501](#1501))
- [**breaking**] Add `Package::validate` and return `ExtensionRegistry`
in helpers. ([#1507](#1507))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
@ss2165 ss2165 mentioned this pull request Oct 9, 2024
This was referenced Oct 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2024
## 🤖 New release
* `hugr`: 0.13.0 -> 0.13.1 (✓ API compatible changes)
* `hugr-core`: 0.10.0 -> 0.13.1 (✓ API compatible changes)
* `hugr-model`: 0.1.0 -> 0.13.1 (✓ API compatible changes)
* `hugr-passes`: 0.8.2 -> 0.13.1 (✓ API compatible changes)
* `hugr-cli`: 0.6.1 -> 0.13.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

##
[0.13.1](hugr-v0.13.0...hugr-v0.13.1)
- 2024-10-14

### New Features

- return replaced ops from lowering
([#1568](#1568))
- Make `BuildHandle::num_value_outputs` public
([#1560](#1560))
- `FunctionBuilder::add_{in,out}put`
([#1570](#1570))
- Binary serialisation format for hugr-model based on capnproto.
([#1557](#1557))
</blockquote>

## `hugr-core`
<blockquote>

##
[0.13.1](hugr-core-v0.10.0...hugr-core-v0.13.1)
- 2024-10-14

### New Features

- Make `BuildHandle::num_value_outputs` public
([#1560](#1560))
- Binary serialisation format for hugr-model based on capnproto.
([#1557](#1557))
- `FunctionBuilder::add_{in,out}put`
([#1570](#1570))
</blockquote>

## `hugr-model`
<blockquote>

##
[0.13.1](hugr-model-v0.1.0...hugr-model-v0.13.1)
- 2024-10-14

### New Features

- Binary serialisation format for hugr-model based on capnproto.
([#1557](#1557))
</blockquote>

## `hugr-passes`
<blockquote>

##
[0.13.1](hugr-passes-v0.8.2...hugr-passes-v0.13.1)
- 2024-10-14

### New Features

- return replaced ops from lowering
([#1568](#1568))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.6.0 (2024-09-04)

### Features

- [**breaking**] Allow registry specification in `run_dump`
([#1501](#1501))
- [**breaking**] Add `Package::validate` and return `ExtensionRegistry`
in helpers. ([#1507](#1507))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Agustín Borgna <[email protected]>
Co-authored-by: Agustín Borgna <[email protected]>
Co-authored-by: Alec Edgington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants