fix!: Make list length op give back the list #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 127 127
Lines 21740 21740
Branches 18740 18740
=======================================
Hits 19008 19008
Misses 1964 1964
Partials 768 768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cqc-alec
approved these changes
Oct 3, 2024
| @@ -189,6 +189,22 @@ | |||
| } | |||
| ], | |||
| "output": [ | |||
| { | |||
There was a problem hiding this comment.
Seems wrong that we should have this file duplicated in source control, but that's another issue.
This was referenced Oct 3, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
## 🤖 New release * `hugr`: 0.12.1 -> 0.13.0 (✓ API compatible changes) * `hugr-core`: 0.9.1 -> 0.10.0 (✓ API compatible changes) * `hugr-passes`: 0.8.1 -> 0.8.2 (✓ API compatible changes) * `hugr-cli`: 0.6.0 -> 0.6.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.13.0 (2024-10-08) ### Bug Fixes - [**breaking**] Make list length op give back the list ([#1547](#1547)) ### Features - [**breaking**] Allow CustomConsts to (optionally) be hashable ([#1397](#1397)) - Add an `OpLoadError` variant of `BuildError`. ([#1537](#1537)) - [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return removed weights ([#1516](#1516)) - Draft for `hugr-model` with export, import, parsing and pretty printing ([#1542](#1542)) </blockquote> ## `hugr-core` <blockquote> ## 0.10.0 (2024-10-08) ### Bug Fixes - [**breaking**] Make list length op give back the list ([#1547](#1547)) ### Features - [**breaking**] Allow CustomConsts to (optionally) be hashable ([#1397](#1397)) - Add an `OpLoadError` variant of `BuildError`. ([#1537](#1537)) - [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return removed weights ([#1516](#1516)) - Draft for `hugr-model` with export, import, parsing and pretty printing ([#1542](#1542)) </blockquote> ## `hugr-passes` <blockquote> ## 0.8.1 (2024-09-04) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0](hugr-py-v0.8.1...hugr-py-v0.9.0) (2024-10-14) ### ⚠ BREAKING CHANGES * `Package` moved to new `hugr.package` module * The `length` op in the std `collections` extensions now also returns the list. ### Features * `instantiate` method for `OpDef` ([#1576](#1576)) ([36548ab](36548ab)), closes [#1512](#1512) * define wrappers around package that point to internals ([#1573](#1573)) ([f74dbf3](f74dbf3)) * to/from json for extension/package ([#1575](#1575)) ([f8bf61a](f8bf61a)), closes [#1523](#1523) ### Bug Fixes * Make list length op give back the list ([#1547](#1547)) ([cf31698](cf31698)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1543.
BREAKING CHANGE: The
lengthop in the stdcollectionsextensions now also returns the list.