-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Return Cow<Signature>
where possible
#1743
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
+ Coverage 86.27% 86.28% +0.01%
==========================================
Files 179 179
Lines 32476 32513 +37
Branches 29388 29425 +37
==========================================
+ Hits 28018 28054 +36
- Misses 2758 2759 +1
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big +1 to this, although I have not looked in detail.
Should we consider returning a Signature struct that contains Cow<TypeRow>, Cow<TypeRow>, Cow<ExtensionSet>
....?
There's another discussion on what to do about type_rows, but yes we should do some sharing at some point. This was just a really low hanging fruit for optimisation. |
I had to add a small workaround for #1758, since now we actually check the extension_reqs that come from the serialized hugr. I'll fix it in another PR |
2a03217
to
a9732c6
Compare
Cow<Signature>
where possibleCow<Signature>
where possible
Closes #1741