Add tomtom geocoder (v3) #2216
Merged
Add tomtom geocoder (v3) #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 3, 2019
Jesus89
suggested changes
Jan 3, 2019
| "FASTLY_API_KEY": "", | ||
| "FASTLY_CARTODB_SERVICE": "" | ||
| "FASTLY_CARTODB_SERVICE": "", |
There was a problem hiding this comment.
This is really nice @elenatorro
Hopefully we'll have really geocoder smoooooth changes in the future 👍
There was a problem hiding this comment.
I'm still testing this, this is just too complicated for something that should be more simple, let's see if we can fix it :)
| @@ -51,17 +51,17 @@ describe('cdb.geo.ui.Search', function() { | |||
| }, | |||
| type: undefined | |||
| }; | |||
| cdb.geo.geocoder.MAPBOX.geocode = function(address, callback) { | |||
| cdb.geo.geocoder[this.view.GEOCODER_SERVICE].geocode = function(address, callback) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: