Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instancing #3048

Merged
merged 11 commits into from
Sep 28, 2015
Merged

Instancing #3048

merged 11 commits into from
Sep 28, 2015

Conversation

lilleyse
Copy link
Contributor

Continuation of #3023 for issue #3001

I checked that instancing works the same on Edge and IE, as the vao extension isn't supported in either.

I added a test inside the Sandcastle dev folder. So far the performance results show that instancing and batching are typically equal for fps. Though instancing does offer some speed improvements when the billboards are constantly updating.

For test coverage, the instancing and batched code paths are very similar and even basic tests should cover most of the divergences. I did edit the non-instancing test to be slightly more robust. The code coverage for BillboardCollection is 98%.

I'll have the model instancing code up after these changes are reviewed.

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 28, 2015

Though instancing does offer some speed improvements when the billboards are constantly updating.

What are the numbers? Are they significant?

Also, it may be hard to measure (check the GPU process), but did you observe a memory savings?

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 28, 2015

Merging this into instancing-ready-for-master. Please open the model instancing PR into this branch too.

pjcozzi added a commit that referenced this pull request Sep 28, 2015
@pjcozzi pjcozzi merged commit 37949ed into CesiumGS:instancing-ready-for-master Sep 28, 2015
@pjcozzi pjcozzi mentioned this pull request Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants