-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instancing #3048
Merged
pjcozzi
merged 11 commits into
CesiumGS:instancing-ready-for-master
from
lilleyse:instancing
Sep 28, 2015
Merged
Instancing #3048
pjcozzi
merged 11 commits into
CesiumGS:instancing-ready-for-master
from
lilleyse:instancing
Sep 28, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Specs/Renderer/DrawSpec.js
What are the numbers? Are they significant? Also, it may be hard to measure (check the GPU process), but did you observe a memory savings? |
Merging this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3023 for issue #3001
I checked that instancing works the same on Edge and IE, as the vao extension isn't supported in either.
I added a test inside the Sandcastle dev folder. So far the performance results show that instancing and batching are typically equal for fps. Though instancing does offer some speed improvements when the billboards are constantly updating.
For test coverage, the instancing and batched code paths are very similar and even basic tests should cover most of the divergences. I did edit the non-instancing test to be slightly more robust. The code coverage for
BillboardCollection
is 98%.I'll have the model instancing code up after these changes are reviewed.