-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the bug of ktx2's texture minfilter #9876
Conversation
Thanks for the pull request @vtxf!
Reviewers, don't forget to make sure that:
|
I have send CLA. |
This should also fix #9746: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vtxf! This change looks good to me, and this should be good to merge to main
. Since we missed the 1.87 release on this one (sorry about that), could you please merge main
into your branch and update the CHANGES.md entry to put the fix into a new section for the 1.88 release?
I had a couple minor suggestions and this should be ready to go.
Co-authored-by: Eli Bogomolny <[email protected]>
Co-authored-by: Eli Bogomolny <[email protected]>
794342e
to
5da8b47
Compare
Thanks for your suggestions and I have updated the branch. |
Thanks again @vtxf! I pushed a small commit to update CHANGES.md after a mini release we did today. |
It only happens for ktx2 texture. cesium does not use gltf's origin minfilter.
origin:
fixed:
test gltf file:
t2.zip