Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the bug of ktx2's texture minfilter #9876

Merged
merged 4 commits into from
Nov 9, 2021
Merged

fix the bug of ktx2's texture minfilter #9876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a3156d
fix the bug of ktx2's texture minfilter
vtxf Oct 15, 2021
61673ce
Update CHANGES.md
vtxf Nov 6, 2021
5da8b47
Update CONTRIBUTORS.md
vtxf Nov 6, 2021
37fa786
Merge branch 'main' into fix-minfilter-bug
ebogo1 Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

### 1.88 - 2021-12-1

##### Fixes :wrench:

- Fixed a bug with .ktx2 textures having an incorrect minification filter. [#9876](https://github.com/CesiumGS/cesium/pull/9876/)

### 1.87.1 - 2021-11-09

##### Additions :tada:
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
- [Mark Aubin](https://github.com/markaubin)
- [Michael Shantzis](https://github.com/shantzis1962)
- [Sebastian Fernandez](https://github.com/SebastianPFernandez)
- Beijing Xibushijie
- [Tang Xiaofei](https://github.com/vtxf)

## [Individual CLA](Documentation/Contributors/CLAs/individual-contributor-license-agreement-v1.0.pdf)

Expand Down
2 changes: 1 addition & 1 deletion Source/Scene/Model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2934,7 +2934,7 @@ function createTexture(gltfTexture, model, context) {
);
}

var minificationFilter;
var minificationFilter = sampler.minificationFilter;
if (
!defined(gltfTexture.mipLevels) &&
(minFilter === TextureMinificationFilter.NEAREST_MIPMAP_NEAREST ||
Expand Down