Update libp2p to ESM version #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
wemeetagain
force-pushed
the
cayman/update-libp2p
branch
from
81e9924 to
c0168a2
Compare
|
@wemeetagain : is there an estimate on when this will be completed? I'm asking because am hoping Lodestar can use the "canary" version of js-libp2p to provide feedback on the resource protection mechanisms that have recently been introduced. |
wemeetagain
force-pushed
the
cayman/update-libp2p
branch
from
c0168a2 to
687b0ae
Compare
wemeetagain
force-pushed
the
cayman/update-libp2p
branch
from
687b0ae to
764ecad
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
|
This is ready for initial review, the last remaining items to fix are related to updating stream limits per protocol. |
|
Enabled libp2p metrics and attached a new dashboard exposing the metrics |
|
Thanks for sharing @wemeetagain . No expectation to respond as don't want to create extra work, but if there's a place can point to, I'd be interested in knowing what the remaining work is and if there's anything needed from js-libp2p at this point. |
|
I don't think there's anything remaining on js-libp2p's side that we need. Performance is now mostly on-par or better than our unstable and stable branches. We've redeployed 67da674 across a group in our fleet (roughly 24 hrs ago) and are monitoring metrics to iron out the last remaining things. The big thing we're working through:
|
This was referenced Sep 19, 2022
twoeths
reviewed
Sep 27, 2022
packages/beacon-node/package.json
Outdated
| "libp2p-tcp": "^0.17.2", | ||
| "multiaddr": "^10.0.1", | ||
| "peer-id": "^0.16.0", | ||
| "libp2p": "0.37.3-509e56a", |
There was a problem hiding this comment.
@wemeetagain are there newer versions?
g11tech
reviewed
Sep 27, 2022
| } | ||
|
|
||
| // create metric if undefined | ||
| if (metrics[protocol] === undefined) { |
There was a problem hiding this comment.
shouldn't we just add protocol in labelNames and simplify this
There was a problem hiding this comment.
I think not, bc they split out the direction. eg: would be helpful to see if we're spammed with identify requests, but not responding.
There was a problem hiding this comment.
Oh, just add protocol as an additional label. Yes good idea. Lets tackle metrics cleanup in a separate PR.
g11tech
approved these changes
Sep 27, 2022
|
cc @achingbrain we finally did it buddy |
This was referenced Sep 27, 2022
Closed
|
Some different gossipsub metrics I notice after 6h-7h (in a 12h timeframe):
|
dapplion
reviewed
Sep 29, 2022
| "@types/tmp": "^0.2.0", | ||
| "@types/varint": "^6.0.0", | ||
| "eventsource": "^2.0.2", | ||
| "leveldown": "^6.1.1", |
There was a problem hiding this comment.
oh, why is leveldown required? For libp2p datastore? If so, @wemeetagain can you motivate upstream dep to move to level >= 8.0.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to get the latest libp2p, gossipsub, etc updates.
Description
TODO:
Closes #4140
Closes #4043