Do not set udp to enr #4591
Merged
Do not set udp to enr #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
added a commit
that referenced
this pull request
Sep 27, 2022
* WIP * Revert eslint changes * Revert dependency update * Revert dependencies * Revert yarn.lock * Update yarn.lock * Update noise * Fix lint errors * Update discv5 * Fix linter errors * Fix check-types * Fix up libp2p connection manager handling * Update gossipsub * Add import statement * Use upstream GossipsubEvents type * Remove stray lint disable comment * Only ping a single peer when it connects * Update gossipsub * libp2p-gossipsub 3.5.0 * Use libp2p-noise 7.0.3 * Use @libp2p/mplex 4.0.3 * Fix write heap dump in libp2p esm branch (#4387) * Remove 'require' check in writeHeapDump * Fix BELLATRIX_FORK_EPOCH * Update libp2p dependencies * Bump libp2p * Fix heap memory issue * Fix some tests * Fix type error * Fix req/resp 'index out of bounds' issue * Fix linter errors * Add libp2p metrics and dashboard * Update gossipsub and set max outbound buffer size * Update @libp2p/tcp * Update uint8arrays * v0.0.0 * Lint libp2p grafana dashboard * Add leveldown dev dependency * Set msgIdToStrFn to Buffer.toString * Do not set udp to enr (#4591) * Fix e2e reqresp test * Fix lint * Fix unit tests * Update yarn.lock after merge * Update libp2p Co-authored-by: Tuyen Nguyen <[email protected]> Co-authored-by: tuyennhv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix external memory issue, it turns out it has the same root cause to #4579
Description
Do not set udp to enr so that our node do not have to serve
FIND_NODESrequest. This is a work around, the real fix should be in discv5, see this candidate to fix fix: add async await discv5#202External memory has been great for 3 days, on feat1 sm1v: