Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIFE-307] Don't link to orb docs on server #1064

Merged
merged 5 commits into from
Jul 31, 2024
Merged

[LIFE-307] Don't link to orb docs on server #1064

merged 5 commits into from
Jul 31, 2024

Conversation

kira-m
Copy link
Contributor

@kira-m kira-m commented Jul 23, 2024

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Don't link to orb docs when CLI hostname does not point to cloud.

Rationale

=========

Enterprise users don't have access to the regular orb registry.

Considerations

==============

I wasn't sure about changing the default hostname in the tests (it's being set to tempSettings.TestServer.URL()), so instead I removed the string from the relevant tests and added a new test case with the default host to ensure it does get printed.

@kira-m kira-m changed the title Life 307b [LIFE-307] Don't link to orb docs on server Jul 23, 2024
@kira-m kira-m marked this pull request as ready for review July 23, 2024 20:04
@kira-m kira-m requested review from a team as code owners July 23, 2024 20:04
@kira-m kira-m merged commit 30a5049 into develop Jul 31, 2024
1 check passed
@kira-m kira-m deleted the life-307b branch July 31, 2024 17:03
@christian-stephen christian-stephen mentioned this pull request Aug 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants