Cut a new CLI release #1066
Merged
Cut a new CLI release #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #1053 from CircleCI-Public/develop
[LIFE-307] Don't link to orb docs on server
…3-api Use the runner v3 API [ONPREM-237]
ryanwohara
approved these changes
Aug 15, 2024
[LIFE-771] Update CODEOWNERS
tshen815
approved these changes
Aug 21, 2024
There has been a change to how configs are compiled that makes this test invalid. Previously we would allow any random owner ID to be passed in when compiling certified orbs as these were enabled by default and didn't require any checks with the provided owner ID. To support an upcoming feature, now when compiling the config, all provided owner IDs are checked and must exist to validate that the organization allows that type of orb. The CLI can continue to use no owner ID with public certified orbs as tested in the above case. https://github.com/CircleCI-Public/circleci-cli/blob/2766f0e710c8727e346e247f6c779079a79b010c/integration_tests/features/circleci_config.feature#L63-L85
…lidate-test PIPE-4877 Remove config validate test with invalid org ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
Rationale
=========
What was the overarching product goal of this PR as well as any pertinent
history of changes
Considerations
==============
Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious
Screenshots
============
Before
Image or [gif](https://giphy.com/apps/giphycapture)After
Image or gif where change can be clearly seenHere are some helpful tips you can follow when submitting a pull request:
main.make buildin the repository root.make test).--debugflag is often helpful for debugging HTTP client requests and responses.make lint). Note: This requires Docker to run inside a local job.