Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the runner v3 API [ONPREM-237] #1065

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

christian-stephen
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Update the runner CRUD operations to use the runner v3 API instead of v2

Rationale

=========

What was the overarching product goal of this PR as well as any pertinent
history of changes

The runner v2 API is being actively deprecated and will be EoL soon, so the CLI needs to be updated to provide a migration path for CircleCI runner users.

Considerations

==============

Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious

Server 4.6 just recently shipped, marking 4.2 as unsupported. This was the last version that didn't support the runner v3 API.

Screenshots

============

Before

Image or [gif](https://giphy.com/apps/giphycapture)

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@christian-stephen christian-stephen requested a review from a team August 15, 2024 11:34
@christian-stephen christian-stephen force-pushed the ONPREM-237/use-runner-v3-api branch from 4b7fbef to 6fe842f Compare August 15, 2024 11:35
@christian-stephen christian-stephen marked this pull request as ready for review August 15, 2024 11:41
@christian-stephen christian-stephen force-pushed the ONPREM-237/use-runner-v3-api branch from 6fe842f to 2c426d6 Compare August 15, 2024 11:43
@christian-stephen christian-stephen merged commit 6161bd1 into develop Aug 15, 2024
1 check passed
@christian-stephen christian-stephen deleted the ONPREM-237/use-runner-v3-api branch August 15, 2024 12:30
@christian-stephen christian-stephen mentioned this pull request Aug 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants