-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ext 358 pr template #708
Merged
Merged
Ext 358 pr template #708
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
af12be6
Test
corinnesollows dbab03e
revert
corinnesollows 8e31ed5
Adding PR template to CLI
corinnesollows 74de500
Moved file out of folder as many online sources state that this could…
corinnesollows b21940c
Merge branch 'master' into EXT-358-PR-Template
corinnesollows File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Checklist | ||
========= | ||
|
||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have checked for similar issues and haven't found anything relevant. | ||
- [ ] This is not a security issue (which should be reported here: https://circleci.com/security/) | ||
- [ ] I have read [Contribution Guidelines](https://github.com/CircleCI-Public/circleci-cli/blob/master/CONTRIBUTING.md). | ||
|
||
## Changes | ||
======= | ||
|
||
- Put itemized changes here, preferably in imperative mood, i.e. "Add | ||
`functionA` to `fileB`" | ||
|
||
## Rationale | ||
========= | ||
|
||
What was the overarching product goal of this PR as well as any pertinent | ||
history of changes | ||
|
||
## Considerations | ||
============== | ||
|
||
Why you made some of the technical decisions that you made, especially if the | ||
reasoning is not immediately obvious | ||
|
||
## Analytics Events Added | ||
====================== | ||
|
||
- `event-name` | ||
|
||
## Screenshots | ||
============ | ||
<h4>Before</h4> | ||
Image or [gif](https://giphy.com/apps/giphycapture) | ||
|
||
<h4>After</h4> | ||
Image or gif where change can be clearly seen | ||
|
||
## **Here are some helpful tips you can follow when submitting a pull request:** | ||
|
||
1. Fork [the repository](https://github.com/CircleCI-Public/circleci-cli) and create your branch from `master`. | ||
2. Run `make build` in the repository root. | ||
3. If you've fixed a bug or added code that should be tested, add tests! | ||
4. Ensure the test suite passes (`make test`). | ||
5. The `--debug` flag is often helpful for debugging HTTP client requests and responses. | ||
6. Format your code with [gofmt](https://golang.org/cmd/gofmt/). | ||
7. Make sure your code lints (`make lint`). Note: This requires Docker to run inside a local job. |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are analytics events a thing in this repo? Did a quick search on the repo which didn't show anything 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no I only saw this after I saw the approval and merged! There's a way to prevent that if you make your commenta as change request 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries. good point, noted for next time 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #709 to address 🙂