Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: Print filled pipeline values on validate & process #855

Merged
merged 2 commits into from
Mar 3, 2023
Merged

task: Print filled pipeline values on validate & process #855

merged 2 commits into from
Mar 3, 2023

Conversation

zbenhadi
Copy link
Contributor

No description provided.

@zbenhadi zbenhadi requested a review from a team as a code owner February 28, 2023 09:33
@JulesFaucherre JulesFaucherre force-pushed the DEVEX-545-print-filled-pipeline-values-on-cli-commands-for-config-validate-process branch from ddec9cb to be54c96 Compare March 3, 2023 09:05
@JulesFaucherre JulesFaucherre merged commit 1c116d3 into develop Mar 3, 2023
@JulesFaucherre JulesFaucherre deleted the DEVEX-545-print-filled-pipeline-values-on-cli-commands-for-config-validate-process branch March 3, 2023 09:12
@wyardley wyardley mentioned this pull request Mar 8, 2023
Closed
wyardley added a commit to wyardley/circleci-cli that referenced this pull request Mar 8, 2023
@wyardley
feat: allow hiding pipeline values in validation output
9ee9c17 
- Add a `-q` / `--quiet` flag to support suppressing the pipeline values
  added in CircleCI-Public#855
- Print the config values one line at a time, and add newlines

Fixes CircleCI-Public#860
@wyardley wyardley mentioned this pull request Mar 8, 2023
Merged
7 tasks
wyardley added a commit to wyardley/circleci-cli that referenced this pull request Mar 13, 2023
@wyardley
feat: allow hiding pipeline values in validation output
08875a4 
- Add a `-q` / `--quiet` flag to support suppressing the pipeline values
  added in CircleCI-Public#855
- Print the config values one line at a time, and add newlines
- Write to stderr so that outputting to a file won't generate invalid
  YAML when writing files to stdout
Fixes CircleCI-Public#860
wyardley added a commit to wyardley/circleci-cli that referenced this pull request Mar 13, 2023
@wyardley
feat: allow hiding pipeline values in validation output
3aa6bb4 
- Add a `-q` / `--quiet` flag to support suppressing the pipeline values
  added in CircleCI-Public#855
- Print the config values one line at a time, and add newlines
- Write to stderr so that outputting to a file won't generate invalid
  YAML when writing files to stdout
Fixes CircleCI-Public#860
@wyardley
Copy link
Contributor

Hi - could you all take a look at #860 / #861 (would also be good to get a little more information on what the goal of this change was). As mentioned by other commenters in #860, this has some worse effects than just being hard to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesFaucherre JulesFaucherre JulesFaucherre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbenhadi @wyardley @JulesFaucherre