Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Print filled pipeline values on validate & process #855

Merged
merged 2 commits into from
Mar 3, 2023
Merged

task: Print filled pipeline values on validate & process #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4983470
task: Print filled pipeline values on validate & process
zbenhadi Feb 28, 2023
be54c96
task: Print filled pipeline values on validate & process
zbenhadi Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions cmd/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,15 +138,19 @@ func validateConfig(opts configOptions, flags *pflag.FlagSet) error {
}

//if no orgId provided use org slug
values := pipeline.LocalPipelineValues()
fmt.Println("Validating config with following values")
printValues(values)

orgID, _ := flags.GetString("org-id")
if strings.TrimSpace(orgID) != "" {
response, err = api.ConfigQuery(opts.cl, path, orgID, nil, pipeline.LocalPipelineValues())
response, err = api.ConfigQuery(opts.cl, path, orgID, nil, values)
if err != nil {
return err
}
} else {
orgSlug, _ := flags.GetString("org-slug")
response, err = api.ConfigQueryLegacy(opts.cl, path, orgSlug, nil, pipeline.LocalPipelineValues())
response, err = api.ConfigQueryLegacy(opts.cl, path, orgSlug, nil, values)
if err != nil {
return err
}
Expand Down Expand Up @@ -192,15 +196,19 @@ func processConfig(opts configOptions, flags *pflag.FlagSet) error {
}

//if no orgId provided use org slug
values := pipeline.LocalPipelineValues()
fmt.Println("Processing config with following values")
printValues(values)

orgID, _ := flags.GetString("org-id")
if strings.TrimSpace(orgID) != "" {
response, err = api.ConfigQuery(opts.cl, opts.args[0], orgID, params, pipeline.LocalPipelineValues())
response, err = api.ConfigQuery(opts.cl, opts.args[0], orgID, params, values)
if err != nil {
return err
}
} else {
orgSlug, _ := flags.GetString("org-slug")
response, err = api.ConfigQueryLegacy(opts.cl, opts.args[0], orgSlug, params, pipeline.LocalPipelineValues())
response, err = api.ConfigQueryLegacy(opts.cl, opts.args[0], orgSlug, params, values)
if err != nil {
return err
}
Expand All @@ -227,3 +235,9 @@ func packConfig(opts configOptions) error {
func migrateConfig(opts configOptions) error {
return proxy.Exec([]string{"config", "migrate"}, opts.args)
}

func printValues(values pipeline.Values) {
for key, value := range values {
fmt.Printf("\t%s:\t%s", key, value)
}
}