Dlc purge #879
Merged
Dlc purge #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delete unused code These fields are never read from, so we can delete them. * Delete code that doesn't do anything This code has no effect (the endpoint variable is never used, nor the value being written back to the struct it came from). * Allow creating rest clients directly not from conf Split the New into two different functions, one that takes exactly what is needed to create the struct, and another that is able to assemble these values from the config. * Create a client for speaking to dl.circleci.com - Also, add code for calling the DLC purge endpoint * Add the command to purge DLC --------- Co-authored-by: Abraham Tewa <[email protected]> Co-authored-by: JulesFaucherre <[email protected]>
JulesFaucherre
approved these changes
Mar 21, 2023
…olvers to an internal service
…PE-2315/remove-api-service-from-config-compilation PIPE-2315 - Removes API-Service from config compilation
christian-stephen
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.