Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIPE-2315 - Changes behaviour such that process and validate commands respect server hosts #880

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

elliotforbes
Copy link
Contributor

@elliotforbes elliotforbes commented Mar 22, 2023

This PR Changes behaviour for the config process and validate commands to respect the --host flag when it's set to a non-default host.

This improves the UX of the changes introduced in the last PR such that customers don't have to also specify --config-api-host.

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • When instantiating the command, use the host option if it's not equal to the default host. This effectively allows server setups to see no behavioural change for these commands.

Validation

  • ./build/darwin/amd64/circleci config --host https://k9s.sphereci.com validate .circleci/config.yml --org-slug gh/circleci - goes to correct https://k9s.sphereci.com/api/v2/me/collaborations and https://k9s.sphereci.com/api/v2/compile-config-with-defaults urls for config compilation
  • ./build/darwin/amd64/circleci config validate .circleci/config.yml --org-slug gh/circleci - goes to circleci.com and api.circleci.com respectively
  • config validation continues to work for private orbs
  • config processing continues to work for private orbs

@elliotforbes elliotforbes requested a review from a team as a code owner March 22, 2023 15:29
…pect the --host flag when it's set to a non-default host
@elliotforbes elliotforbes force-pushed the PIPE-2315-bugfix-server-issue branch from 420c5bd to 5298cf6 Compare March 22, 2023 15:56
@elliotforbes elliotforbes merged commit d3a9440 into develop Mar 22, 2023
@elliotforbes elliotforbes deleted the PIPE-2315-bugfix-server-issue branch March 22, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants