Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting for config validation #896

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Mar 30, 2023

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Put itemized changes here, preferably in imperative mood, i.e. "Add
    functionA to fileB"

Rationale

Reintroduces the output style introduced in #861 to resolve #860, but reverted in #884

Considerations

The existing output is hard to read and unpleasant to look at. I'm not sure if the extra newline is intentional (between "No org id or slug has been provided"

Screenshots

Before

image

After

image

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

Reintroduces the output style introduced in CircleCI-Public#861 to resolve CircleCI-Public#860, but
reverted in CircleCI-Public#884
@wyardley wyardley requested a review from a team as a code owner March 30, 2023 17:29
@wyardley wyardley mentioned this pull request Mar 30, 2023
15 tasks
@elliotforbes elliotforbes merged commit c6fe24f into CircleCI-Public:develop Mar 31, 2023
wyardley added a commit to wyardley/circleci-cli that referenced this pull request Apr 5, 2023
Resolve some issues from CircleCI-Public#861 and CircleCI-Public#896

- Suppress some whitespace when verbose output is not enabled
- Write to stderr again
- Use "%v" instead of "%s" so that "number" in pipeline values gets
  printed correctly
- Sort values to provide stable output order for pipeline values
wyardley added a commit to wyardley/circleci-cli that referenced this pull request Apr 5, 2023
Resolve some issues from CircleCI-Public#861 and CircleCI-Public#896

- Suppress some whitespace when verbose output is not enabled
- Write to stderr again
- Use "%v" instead of "%s" so that "number" in pipeline values gets
  printed correctly
- Sort values to provide stable output order for pipeline values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

messy validation output
3 participants