Additional formatting updates for config validation #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
commented
Apr 5, 2023
| // Provide a stable sort order for printed values | ||
| keys := make([]string, 0, len(values)) | ||
| for k := range values { | ||
| keys = append(keys, k) |
There was a problem hiding this comment.
open to suggestion here; I didn't find a way to do this in place for the original map.
There was a problem hiding this comment.
I think this is fine - it's nice and explicit what's going on and we're not necessarily resource constrained here
Resolve some issues from CircleCI-Public#861 and CircleCI-Public#896 - Suppress some whitespace when verbose output is not enabled - Write to stderr again - Use "%v" instead of "%s" so that "number" in pipeline values gets printed correctly - Sort values to provide stable output order for pipeline values
wyardley
force-pushed
the
wyardley/config-values-again
branch
from
d5ddf96 to
cb2d3e6
Compare
elliotforbes
reviewed
Apr 5, 2023
| } | ||
| sort.Strings(keys) |
There was a problem hiding this comment.
This is a nice improvement 👌🏼
elliotforbes
approved these changes
Apr 5, 2023
JulesFaucherre
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
%vinstead of%sso that "number" in pipeline values gets printed correctlyRationale
@elliotforbes sorry - I think one or both of us missed that
numberdoesn't get printed out right when%sis used vs%v. This also moves most of the verbose output to stderr (esp. could be an issue for subcommands that output yaml otherwise). It also gets rid of the extra newline before validate output in the case where verbose output is not usedSee #860 for original context. Resolve some issues from #861 and #896
Considerations
Screenshots
============
Before
After
Here are some helpful tips you can follow when submitting a pull request:
main.make buildin the repository root.make test).--debugflag is often helpful for debugging HTTP client requests and responses.make lint). Note: This requires Docker to run inside a local job.