-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRERELEASE] Support SSH reruns [RT-1201] #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
from
June 20, 2023 12:56
1303343
to
e24fb49
Compare
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
2 times, most recently
from
June 28, 2023 11:45
3cb1f87
to
a478fad
Compare
atulsingh0
approved these changes
Jun 28, 2023
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
5 times, most recently
from
June 29, 2023 10:37
05cda75
to
0886f3c
Compare
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
from
June 29, 2023 11:14
0886f3c
to
8bac922
Compare
4 tasks
christian-stephen
changed the title
Support SSH reruns [RT-1201]
[PRERELEASE] Support SSH reruns [RT-1201]
Jun 29, 2023
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
from
June 29, 2023 13:44
8bac922
to
b724b27
Compare
Stuart133
approved these changes
Jun 29, 2023
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
4 times, most recently
from
July 3, 2023 19:10
c94e26c
to
8d0e264
Compare
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
2 times, most recently
from
July 11, 2023 15:47
56ec04b
to
99fb345
Compare
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
2 times, most recently
from
November 2, 2023 09:45
d4cac73
to
9783d27
Compare
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
4 times, most recently
from
November 2, 2023 14:04
e66687e
to
d8b75e1
Compare
christian-stephen
force-pushed
the
cs/ssh-reruns
branch
from
November 8, 2023 00:54
d8b75e1
to
afb668a
Compare
ryanwohara
approved these changes
Nov 8, 2023
jrahme-cci
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://circleci.atlassian.net/browse/RT-1201
Background
During a Hack Week initiative, work was done that leveraged the new Kubernetes Gateway API resources to support SSH reruns on container runner. Some of the barriers to our earlier attempts and designs of supporting SSH reruns on container runner were limitations of existing Kubernetes Ingresses, which are HTTP-specific and have limited routing capabilities to specific pods (an unusual pattern, but a necessity for SSH).
Note that these Helm chart updates are interdependent on PR https://github.com/circleci/circleci-runner/pull/478
Changes
Testing
246161830-71180148-5462-44ac-be3f-a05da58affc0.webm