Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRERELEASE] Support SSH reruns [RT-1201] #16

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

christian-stephen
Copy link
Contributor

@christian-stephen christian-stephen commented Jun 20, 2023

Jira ticket: https://circleci.atlassian.net/browse/RT-1201

Background

During a Hack Week initiative, work was done that leveraged the new Kubernetes Gateway API resources to support SSH reruns on container runner. Some of the barriers to our earlier attempts and designs of supporting SSH reruns on container runner were limitations of existing Kubernetes Ingresses, which are HTTP-specific and have limited routing capabilities to specific pods (an unusual pattern, but a necessity for SSH).

Note that these Helm chart updates are interdependent on PR https://github.com/circleci/circleci-runner/pull/478

Changes

  • Add the necessary Kubernetes Gateway API resources for SSH reruns to the Helm chart
  • Expose the necessary configuration parameters for SSH in the values file (note that SSH is fully opt-in, and nothing additional will be installed to the cluster if disabled)

Testing

  • Add various Helm unit tests testing the installation and configuration of Gateway API resources when SSH reruns are enabled
  • Demo video using the Envoy Gateway implementation on GKE:
246161830-71180148-5462-44ac-be3f-a05da58affc0.webm

@christian-stephen christian-stephen force-pushed the cs/ssh-reruns branch 2 times, most recently from 3cb1f87 to a478fad Compare June 28, 2023 11:45
@christian-stephen christian-stephen changed the title Support SSH reruns Support SSH reruns [RT-1201] Jun 28, 2023
@christian-stephen christian-stephen marked this pull request as ready for review June 28, 2023 11:50
@christian-stephen christian-stephen requested a review from a team as a code owner June 28, 2023 11:50
@christian-stephen christian-stephen force-pushed the cs/ssh-reruns branch 5 times, most recently from 05cda75 to 0886f3c Compare June 29, 2023 10:37
do Outdated Show resolved Hide resolved
@christian-stephen christian-stephen changed the title Support SSH reruns [RT-1201] [PRERELEASE] Support SSH reruns [RT-1201] Jun 29, 2023
@christian-stephen christian-stephen marked this pull request as draft June 29, 2023 15:14
@christian-stephen christian-stephen force-pushed the cs/ssh-reruns branch 4 times, most recently from c94e26c to 8d0e264 Compare July 3, 2023 19:10
@christian-stephen christian-stephen force-pushed the cs/ssh-reruns branch 2 times, most recently from 56ec04b to 99fb345 Compare July 11, 2023 15:47
@christian-stephen christian-stephen force-pushed the cs/ssh-reruns branch 2 times, most recently from d4cac73 to 9783d27 Compare November 2, 2023 09:45
@christian-stephen christian-stephen force-pushed the cs/ssh-reruns branch 4 times, most recently from e66687e to d8b75e1 Compare November 2, 2023 14:04
@christian-stephen christian-stephen marked this pull request as ready for review November 8, 2023 00:56
@christian-stephen christian-stephen merged commit 7df49b8 into main Nov 9, 2023
1 check passed
@christian-stephen christian-stephen deleted the cs/ssh-reruns branch November 9, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants