Use helm unittest for unit testing and add a basic test [RT-1201] #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+21
to
+22
| set -x | ||
| if [ "$(./do version)" == "$(git show "${prev}:Chart.yaml" | grep version | sed -nE 's/.*"(.*)".*/\1/p')" ]; then |
There was a problem hiding this comment.
Found a small bug with the version bump check. If you had multiple commits in a single PR and bumped the version in an earlier commit, it would fail. That's because "$(git show HEAD^:Chart.yaml should be $(git show "${prev}:Chart.yaml so that it properly checks against main instead of the same branch.
christian-stephen
force-pushed
the
RT-1201/unit-tests
branch
from
64bb01e to
e6384f8
Compare
jrahme-cci
approved these changes
Jun 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
Ticket/s: https://circleci.atlassian.net/browse/RT-1201
⚙️ Change
In preparation for PR #16
Change Type:
AC:
✅ Fix
❓ Tests
In CI: https://app.circleci.com/pipelines/github/CircleCI-Public/container-runner-helm-chart/157/workflows/d6d3023d-0c0a-4306-9626-ff061f4448c6/jobs/426/parallel-runs/0/steps/0-108
🗒️ Documentation