Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RT-872] Use the custom service account name if present #5

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

Stuart133
Copy link
Contributor

@Stuart133 Stuart133 commented Dec 7, 2022

We allow a user to specify their own service account rather than having one created by the chart but due to a template bug this name was not getting passed to the deployment which means the default service account is mounted.

This PR means the service account will always be templated, with a default value of default if create is turned off & no service account name is set

Testing

The change was manually tested with helm template to verify the expected output (Shown below)

Before

The relevant snippet from the rendered helm template

  spec:
      terminationGracePeriodSeconds: 18300
      volumes:
        - name: taskpod-config
          configMap:
            name: yeah-container-agent

After

  spec:
      serviceAccountName: custom-name
      terminationGracePeriodSeconds: 18300
      volumes:
        - name: taskpod-config
          configMap:
            name: yeah-container-agent

@Stuart133 Stuart133 requested a review from a team as a code owner December 7, 2022 14:30
@Stuart133 Stuart133 force-pushed the sr/use-service-account branch from fbbbfe4 to 1fe503f Compare December 7, 2022 14:30
@Stuart133 Stuart133 force-pushed the sr/use-service-account branch from 1fe503f to 44b24de Compare December 7, 2022 14:56
@Stuart133 Stuart133 force-pushed the sr/use-service-account branch from 44b24de to 14c4a68 Compare December 7, 2022 14:57
@Stuart133 Stuart133 merged commit 0bcc064 into main Dec 19, 2022
@Stuart133 Stuart133 deleted the sr/use-service-account branch March 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants