Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Match TOTP modal to SMS/Voice modal #133

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

cbhernan
Copy link
Collaborator

What does this PR do?

This PR makes the Authenticator modal look the same way as the SMS/Voice modal, which is smaller and extends to the necessary width, and full screen on smaller screens.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 84.89583% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (bba3b6a) to head (538a41b).

Files with missing lines Patch % Lines
lib/views/dialogs/mobile.dart 80.76% 15 Missing ⚠️
lib/utils/BaseMFADialogState.dart 71.42% 8 Missing ⚠️
lib/views/dialogs/authenticator.dart 89.47% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #133      +/-   ##
===============================================
+ Coverage        80.44%   80.47%   +0.02%     
===============================================
  Files               16       17       +1     
  Lines             1028     1019       -9     
===============================================
- Hits               827      820       -7     
+ Misses             201      199       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant