Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Match TOTP modal to SMS/Voice modal #133

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Fix tests for mobile

538a41b
Select commit
Loading
Failed to load commit list.
Draft

[WIP] Match TOTP modal to SMS/Voice modal #133

Fix tests for mobile
538a41b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 0s

80.47% (+0.02%) compared to bba3b6a

View this Pull Request on Codecov

80.47% (+0.02%) compared to bba3b6a

Details

Codecov Report

Attention: Patch coverage is 84.89583% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (bba3b6a) to head (538a41b).

Files with missing lines Patch % Lines
lib/views/dialogs/mobile.dart 80.76% 15 Missing ⚠️
lib/utils/BaseMFADialogState.dart 71.42% 8 Missing ⚠️
lib/views/dialogs/authenticator.dart 89.47% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #133      +/-   ##
===============================================
+ Coverage        80.44%   80.47%   +0.02%     
===============================================
  Files               16       17       +1     
  Lines             1028     1019       -9     
===============================================
- Hits               827      820       -7     
+ Misses             201      199       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: