Allow download strategies to preprocess download options

[champo]

For now, this is useful only for git when downloading a specific branch.

Related to CocoaPods/CocoaPods#5376.

TODO

• Add test coverage
• Add to README
• Add to changelog

[champo]

Trying to add test coverage I realized that Executable.execute_command is not available in this gem. And my ruby-fu is not strong enough to use API.execute_command from this gem.

[segiddins]

just use git command or git! command

[champo]

those are instance methods, so they're not available here. it's a class method to avoid instancing downloaders just to preprocess options.

[segiddins]

ah silly me. we'll figure out how to make that work :) In the meantime, you can do something hacky that'll let you start writing tests / playing around with it if you want

[segiddins]

diff --git a/lib/cocoapods-downloader/api.rb b/lib/cocoapods-downloader/api.rb
index 9375f10..2e6f079 100644
--- a/lib/cocoapods-downloader/api.rb
+++ b/lib/cocoapods-downloader/api.rb
@@ -4,6 +4,8 @@ module Pod
     # the UI of other gems.
     #
     module API
+      module_function
+
       # Executes
       # @return [String] the output of the command.
       #

and then use API.execute_command

[segiddins]

alternatively,

diff --git a/lib/cocoapods-downloader/api_exposable.rb b/lib/cocoapods-downloader/api_exposable.rb
index 0ed5f3a..efcf236 100644
--- a/lib/cocoapods-downloader/api_exposable.rb
+++ b/lib/cocoapods-downloader/api_exposable.rb
@@ -12,6 +12,7 @@ module Pod
           raise 'Only a module *or* is required, not both.'
         end
         include mod
+        extend mod
       end

       alias override_api expose_api

so overriding still works

[champo]

Thanks! I went with the second patch.

[segiddins]

maybe extract this into downloader_class_from_options to avoid duplication?

[champo]

@segiddins I think this is ready, can you give it a look? thanks!

[segiddins]

CocoaPods

[champo]

@segiddins done!

[segiddins]

👍🏻