Don't convert branch name to commit hash #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the trade-off here is between initial clone and updates? So maybe a better approach is possible |
|
Iop |
|
This is a big breaking change, I don't think we're going to be able to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm completely oblivious to rationale for #57, so sorry if this doesn't make any sense.
When a branch name is present, it's replaced by a git hash. This breaks shallow clones (as remarked by @simson2010 #57 (comment).
It also makes git submodules even more painful, in particular when a branch points to a different origin than master. For example in https://github.com/Sjors/libwally-swift/commits/dev contains a submodule that points to a fork.
This PR removes the conversion from branch name to commit hash.