[Http] add default User-Agent string to cURL requests #96
Conversation
lib/cocoapods-downloader/base.rb
Outdated
| "cocoapods/#{version}" | ||
| end | ||
|
|
||
| # @return [String] Shell command to add the custom User-Agent. |
There was a problem hiding this comment.
why does this say it's a shell command? I thought -A accepts a string to specify as the user agent
this also seems specific to Http because it's only used for cURL, so maybe it shouldn't be in Base at all
lib/cocoapods-downloader/http.rb
Outdated
|
|
||
| # @return [String] cURL command flag to add the custom User-Agent. | ||
| # | ||
| def self.user_agent_command |
lib/cocoapods-downloader/base.rb
Outdated
| # @return [String] the User-Agent string | ||
| # | ||
| def self.user_agent_string version = Pod::VERSION | ||
| "cocoapods/#{version}" |
There was a problem hiding this comment.
nit: can we make this CocoaPods/#{version}?
lib/cocoapods-downloader/http.rb
Outdated
| private | ||
|
|
||
| executable :curl | ||
|
|
||
| def download_file(full_filename) | ||
| parameters = ['-f', '-L', '-o', full_filename, url, '--create-dirs', '--netrc-optional', '--retry', '2'] | ||
|
|
||
| parameters << user_agent_argument if headers.nil? || headers.none? { |header| header.include?(USER_AGENT_HEADER) } |
There was a problem hiding this comment.
I think header names are case-insensitive, so should we do a case-insensitive comparison here?
lib/cocoapods-downloader/base.rb
Outdated
| # | ||
| # @return [String] the User-Agent string | ||
| # | ||
| def self.user_agent_string(version = Pod::VERSION) |
There was a problem hiding this comment.
I dont think Pod::VERSION is actually defined in this gem
There was a problem hiding this comment.
It is not. I've been trying to get a feel for the independence of this Gem from the CocoaPods gem, and have updated to a safer access of Pod::VERSION to try to provide the expected general-case version without the access concern.
Expanding a bit beyond the feature request, I added the the cocoapods-downloader gem version to the User-Agent, so that it looks like: CocoaPods/1.9.1 cocoapods-downloader/1.3.0. If this is not preferred, I'm happy to revert.
There was a problem hiding this comment.
Nice! seems worthwhile to include that
CHANGELOG.md
Outdated
| @@ -4,7 +4,9 @@ | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * None. | |||
| * Add User-Agent to `cURL` requests when downloading source via the `:http` download strategy, unless one was provided by the `:headers` option. | |||
There was a problem hiding this comment.
nit, please add two empty spaces at the end of this line so markdown formatting works.
seanreinhardtapps
force-pushed
the
sr-add-default-user-agent
branch
from
66ee297 to
029d9fc
Compare
…provided by :headers
seanreinhardtapps
force-pushed
the
sr-add-default-user-agent
branch
from
029d9fc to
8179b8f
Compare
|
Thanks @seanreinhardtapps! |
closes CocoaPods/CocoaPods#9619