-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Tpay Pay by Link - happy edition #41
Closed
arti0090
wants to merge
3
commits into
CommerceWeavers:main
from
arti0090:23-direct-transfer-transactions
Closed
[WIP] Tpay Pay by Link - happy edition #41
arti0090
wants to merge
3
commits into
CommerceWeavers:main
from
arti0090:23-direct-transfer-transactions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arti0090
changed the title
Tpay Pay by Link - happy edition
[WIP] Tpay Pay by Link - happy edition
Sep 26, 2024
coldic3
reviewed
Sep 27, 2024
tests/Unit/Form/EventListener/RemoveUnnecessaryPaymentDetailsFieldsListenerTest.php
Show resolved
Hide resolved
lchrusciel
reviewed
Sep 27, 2024
|
||
final class TpayApiBankListProvider implements TpayApiBankListProviderInterface | ||
{ | ||
// TODO make it cached (but here or inside of GetBankGroupListAction?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a task out of it and skip it for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it in this Provider on my last commit
arti0090
force-pushed
the
23-direct-transfer-transactions
branch
from
September 28, 2024 09:40
c0a9e82
to
e059e0a
Compare
Continued in #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.