Add support for paying by redirection directly to a chosen bank #42
Conversation
tests/Unit/Payum/Action/Api/GetTpayTransactionsChannelsTest.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
23-direct-transfer-transactions
branch
5 times, most recently
from
4ba1229 to
6b56e3a
Compare
|
I see there's no API part. Do you plan to add it do this PR or as a separate one? We already have |
| $payload = $this->createRedirectBasedPaymentPayloadFactory->createFrom($payment, $notifyUrl, $localeCode); | ||
|
|
||
| /** @var array{tpay?: array{pay_by_link_channel_id?: string}} $paymentDetails */ | ||
| $paymentDetails = $payment->getDetails(); |
There was a problem hiding this comment.
As previously, PaymentDetails object
There was a problem hiding this comment.
I think here we should extend the PaymentDetails object as later I cant check if key exists, and get value of 'pay_by_link_channel_id' so in other payload factories same issue would exist. I am adding this comment as reference for the improvements task
There was a problem hiding this comment.
This object is our own, so you can just put what you need there :D
jakubtobiasz
changed the title
jakubtobiasz
changed the title
|
Comments that were as improvements and the API one has been added as task on board and refererenced there - https://github.com/orgs/CommerceWeavers/projects/9/views/1?filterQuery=&pane=issue&itemId=82030548 |
arti0090
force-pushed
the
23-direct-transfer-transactions
branch
from
6b56e3a to
dea6123
Compare
Closes #23