Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafted a document for withdrawals for capella #412

Merged
merged 16 commits into from
Jan 31, 2023
Merged

Drafted a document for withdrawals for capella #412

merged 16 commits into from
Jan 31, 2023

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Dec 6, 2022

Hopefully this is a good start for documenting the capella upgrade and what users need to know.

I referenced ethdo, which is a tool we don't maintain, but it's also the only tool i know of at the moment that has this functionality...

The capella upgrade is not set to release on a specific date yet, but this kind of concept document will start being useful very soon.

ref. Consensys/teku#5680 and Consensys/teku#6482

I can't run python scripts on my mac, so I'm yet to see how this looks rendered... sorry in advance...

Pull request checklist

Use the following template to make sure your PR fits the Teku documentation standard.

Before creating the PR

Make sure that:

Describe the change

Issue fixed

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • CircleCI workflow
  • Build and QA tools (for example lint or vale)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

Hopefully this is a good start for documenting the capella upgrade and what users need to know.

I referenced ethdo, which is a tool we don't maintain, but it's also the only tool i know of at the moment that has this functionality...

The capella upgrade is not set to release on a specific date yet, but this kind of concept document will start being useful very soon.

ref. Consensys/teku#5680 and Consensys/teku#6482
@bgravenorst bgravenorst self-assigned this Jan 8, 2023
docs/HowTo/Withdrawals.md Outdated Show resolved Hide resolved
docs/HowTo/Withdrawals.md Outdated Show resolved Hide resolved
@bgravenorst bgravenorst marked this pull request as ready for review January 17, 2023 21:31
@bgravenorst bgravenorst requested a review from a team as a code owner January 17, 2023 21:31
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this because I opened the PR, but in principal it looks good to me, raised 1 nit.

Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst merged commit 72b9945 into Consensys:master Jan 31, 2023
@rolfyone rolfyone deleted the withdrawals-doc-start branch January 31, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants