-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drafted a document for withdrawals for capella #412
Merged
bgravenorst
merged 16 commits into
Consensys:master
from
rolfyone:withdrawals-doc-start
Jan 31, 2023
Merged
Drafted a document for withdrawals for capella #412
bgravenorst
merged 16 commits into
Consensys:master
from
rolfyone:withdrawals-doc-start
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this is a good start for documenting the capella upgrade and what users need to know. I referenced ethdo, which is a tool we don't maintain, but it's also the only tool i know of at the moment that has this functionality... The capella upgrade is not set to release on a specific date yet, but this kind of concept document will start being useful very soon. ref. Consensys/teku#5680 and Consensys/teku#6482
Signed-off-by: bgravenorst <[email protected]>
rolfyone
commented
Jan 11, 2023
rolfyone
commented
Jan 11, 2023
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
rolfyone
commented
Jan 18, 2023
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
bgravenorst
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: bgravenorst <[email protected]>
rolfyone
commented
Jan 31, 2023
rolfyone
commented
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve this because I opened the PR, but in principal it looks good to me, raised 1 nit.
Signed-off-by: bgravenorst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is a good start for documenting the capella upgrade and what users need to know.
I referenced ethdo, which is a tool we don't maintain, but it's also the only tool i know of at the moment that has this functionality...
The capella upgrade is not set to release on a specific date yet, but this kind of concept document will start being useful very soon.
ref. Consensys/teku#5680 and Consensys/teku#6482
I can't run python scripts on my mac, so I'm yet to see how this looks rendered... sorry in advance...
Pull request checklist
Use the following template to make sure your PR fits the Teku documentation standard.
Before creating the PR
Make sure that:
Describe the change
Issue fixed
Impacted parts
For content changes:
For tool changes:
After creating your PR and tests have finished
Make sure that:
and added a preview link.
Preview