Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement withdrawals processing without queues #6321

Closed
StefanBratanov opened this issue Oct 13, 2022 · 0 comments · Fixed by #6423
Closed

Implement withdrawals processing without queues #6321

StefanBratanov opened this issue Oct 13, 2022 · 0 comments · Fixed by #6423
Assignees
@rolfyone
Labels
Epic Capella Issues required to implement Capella upgrade

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Oct 13, 2022 •
edited by rolfyone
Loading

A significant change from 1.3.0-alpha.0, the plan is now to find candidates for withdrawals during block production (or caching on state transition) rather than a large buffer populated during epoch transition.

ethereum/consensus-specs#3068
@StefanBratanov StefanBratanov mentioned this issue Oct 13, 2022
Closed
10 tasks
@rolfyone rolfyone added the Epic Capella Issues required to implement Capella upgrade label Nov 1, 2022
@rolfyone rolfyone self-assigned this Nov 9, 2022
@rolfyone rolfyone changed the title Implement Capella epoch processing Implement withdrawals processing without queues Nov 9, 2022
rolfyone added a commit to rolfyone/teku that referenced this issue Nov 10, 2022
@rolfyone
Added queueless withdrawals for capella
1bcadd0 
 - State was missing `next_withdrawal_index`
 - changed MaxWithdrawalsPerLayload to be int
 - had to breakout process_execution_payload logic so that I could add withdrawals into that, and the spec still does the TTD check in capella which is maybe to cover corner cases, not sure...

 fixes Consensys#6321

Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone mentioned this issue Nov 10, 2022
Merged
2 tasks
rolfyone added a commit that referenced this issue Nov 11, 2022
@rolfyone
Added queueless withdrawals for capella (#6423)
c542914 
 - State was missing `next_withdrawal_index`
 - changed MaxWithdrawalsPerLayload to be int
 - had to breakout process_execution_payload logic so that I could add withdrawals into that, and the spec still does the TTD check in capella which is maybe to cover corner cases, not sure...

 fixes #6321

Signed-off-by: Paul Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfyone rolfyone

Labels
Epic Capella Issues required to implement Capella upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added queueless withdrawals for capella rolfyone/teku
2 participants
@rolfyone @StefanBratanov